Re: [PATCH v1 23/25] contrib: remove 'hooks/multimail'
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 9, 2014, 15:18 UTC
- Message-ID
- <536cf1db3a623_ce316372ecdf@nysa.notmuch>
- In-Reply-To
- <536CED9B.3080706@alum.mit.edu>
Michael Haggerty wrote:
Show 12 quoted lines
> On 05/09/2014 02:58 AM, Felipe Contreras wrote: > > No tests. No chance of ever graduating. > > > > Already out-of-tree. > > > > Cc: Michael Haggerty <mhagger@alum.mit.edu> > > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > Thank you for your input. > > git-multimail is maintained outside of the Git project and is only > distributed along with Git as a convenience to Git users.
I do not see anywhere in contrib/README any hint that contrib is meant for that.
> It does in fact have a test suite, along with some other bits and bobs > that are not needed to use it, in the upstream repository at > > https://github.com/mhagger/git-multimail
Good to know. But IMO the tests should be in git.git as well, or nothing at all.
> What's more, it has a maintainer who doesn't routinely insult other > people on the mailing list,
Aaand skiping the rest. Good bye.
-- Felipe Contreras