Re: [PATCH v1 06/25] contrib: remove 'diffall'

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 9, 2014, 18:50 UTC
Message-ID: <20140509185035.GL9218@google.com>
In-Reply-To: <CAFouetj4A+z2xzciGAbsQ8th8CNwYMd5QTapar4TXRLzGdAqeQ@mail.gmail.com>

Hi Tim,

Tim Henigan wrote:

> On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:

Show 9 quoted lines

>>  contrib/diffall/README      |  31 ------
>>  contrib/diffall/git-diffall | 257 --------------------------------------------
>>  2 files changed, 288 deletions(-)
>>  delete mode 100644 contrib/diffall/README
>>  delete mode 100755 contrib/diffall/git-diffall
>
> I see no problem with removing this script from contrib.  However, the commit message
> should mention that git-difftool learned all the features of git-diffall when the '--dir-diff'
> option was added in v1.7.11 (ca. June 2012).

A few questions:

 * Do you still use git-diffall?  Since it hasn't been a maintenance
   burden, I wouldn't mind keeping it if it still has users.

 * Any thoughts about how to help people who have been using it to
   migrate to difftool?  Would a note in the release notes to look
   into the --dir-diff option to difftool be enough, or are there
   more specific pointers that could be useful?

Once those questions are dealt with, this seems like a nice small cleanup. Thanks for the quick feedback.

Hope that helps, Jonathan