Re: [PATCH v1 04/25] contrib: remove 'buildsystems'

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 9, 2014, 08:14 UTC
Message-ID: <536c8e63448c2_25d198d30c55@nysa.notmuch>
In-Reply-To: <CABPQNSYZ4eWS_9_omZGK5wCD7ap_siEkC10e4ayT8Jp9w1bOSw@mail.gmail.com>

Erik Faye-Lund wrote:

Show 22 quoted lines

> On Fri, May 9, 2014 at 2:58 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > No activity since 2010, no documentation, no tests.
> >
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > ---
> >  contrib/buildsystems/Generators.pm        |  42 --
> >  contrib/buildsystems/Generators/QMake.pm  | 189 ---------
> >  contrib/buildsystems/Generators/Vcproj.pm | 626 ------------------------------
> >  contrib/buildsystems/engine.pl            | 359 -----------------
> >  contrib/buildsystems/generate             |  29 --
> >  contrib/buildsystems/parse.pl             | 228 -----------
> >  6 files changed, 1473 deletions(-)
> >  delete mode 100644 contrib/buildsystems/Generators.pm
> >  delete mode 100644 contrib/buildsystems/Generators/QMake.pm
> >  delete mode 100644 contrib/buildsystems/Generators/Vcproj.pm
> >  delete mode 100755 contrib/buildsystems/engine.pl
> >  delete mode 100755 contrib/buildsystems/generate
> >  delete mode 100755 contrib/buildsystems/parse.pl
> 
> Please don't. This script is useful to build with the MSVC IDE, which
> enables us to use their excellent debugger.

If you want this script to remain in contrib, please:

 a) Write at least a few tests
 b) Write some documentation
 c) Explain why it cannot live outside the git.git repository like other
    tools. [1][2][3]

Cheers.

[1] https://github.com/visionmedia/git-extras [2] https://github.com/mislav/git-deploy [3] https://github.com/git-ftp/git-ftp

-- 
Felipe Contreras