Re: [PATCH v2 18/27] update-ref --stdin: Harmonize error messages

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mar 31, 2014, 22:37 UTC
Message-ID: <5339EE33.7050708@alum.mit.edu>
In-Reply-To: <xmqqy4zq2g0b.fsf@gitster.dls.corp.google.com>

On 03/31/2014 11:51 PM, Junio C Hamano wrote:

Show 18 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> Make (most of) the error messages for invalid input have the same
>> format [1]:
>>
>>     $COMMAND [SP $REFNAME]: $MESSAGE
>>
>> Update the tests accordingly.
>>
>> [1] A few error messages are left with their old form, because
>>     $COMMAND and $REFNAME aren't passed all the way down the call
>>     stack.  Maybe those sites should be changed some day, too.
>>
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>> ---
> 
> Up to this point, modulo nits that have been pointed out separately,
> the series looked reasonably well done.

Thanks for the feedback! Would you like me to expand the commit messages to answer the questions that you asked about the previous patches? And if so, do you want a v3 sent to the list already or should I wait for you to review patches 19-27 first?

Cheers, Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/