Re: [PATCH v2 13/27] t1400: Test that stdin -z update treats empty <newvalue> as zeros
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Mar 31, 2014, 22:20 UTC
- Message-ID
- <5339EA44.1050006@alum.mit.edu>
- In-Reply-To
- <xmqqbnwm3uqw.fsf@gitster.dls.corp.google.com>
On 03/31/2014 11:48 PM, Junio C Hamano wrote:
Show 11 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> This is the (slightly inconsistent) status quo; make sure it doesn't
>> change by accident.
>
> Interesting. So "oldvalue" being empty is "we do not care what it
> is" (as opposed to "we know it must not exist yet" aka 0{40}), and
> "newvalue" being empty is the same as "delete it" aka 0{40}.
>
> That is unfortunate, but I agree it is a good idea to add a test for
> it, so that we will notice when we decide to fix it.Correct. This was discussed at some more length here [1]. In v1 of this patch series I incorrectly changed this behavior, thinking it to have been an accident.
Michael
[1] http://thread.gmane.org/gmane.comp.version-control.git/243731/focus=243773
-- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/