Re: [PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 3, 2014, 15:57 UTC
Message-ID: <xmqq61mqs8wl.fsf@gitster.dls.corp.google.com>
In-Reply-To: <533B9A26.8050303@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 7 quoted lines

> I assumed that rolling back a non-consummated transaction in the case of
> early program death should be the responsibility of the library, not of
> the caller.  If I'm correct, the caller(s) won't have to be modified
> when the atexit facility is added, so I don't see a reason to add it
> before it is needed by a concrete backend.
>
> But you suggest that the caller should be involved.

I didn't say "should". If the library can automatically rollback without being called upon die() anywhere in the system, that is better. The suggestion was because I didn't think you were shooting for such a completeness in the library part, and a possible way out is for the caller to help.