Re: [PATCH v2 16/27] t1400: Test one mistake at a time

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mar 31, 2014, 22:32 UTC
Message-ID: <5339ED15.6040201@alum.mit.edu>
In-Reply-To: <xmqq38hy3umr.fsf@gitster.dls.corp.google.com>

On 03/31/2014 11:50 PM, Junio C Hamano wrote:

Show 19 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> This case wants to test passing a bad refname to the "update" command.
>> But it also passes too few arguments to "update", which muddles the
>> situation: which error should be diagnosed?  So split this test into
>> two:
>>
>> * One that passes too few arguments to update
>>
>> * One that passes all three arguments to "update", but with a bad
>>   refname.
>>
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>>
>> t1400: Add a test of "update" with too few arguments
>>
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> 
> What's happening here?

That was a squashing accident, also pointed out by Brad [1]. The last three lines should be deleted. This and an error in a comment in patch 14/27 that was also pointed out by Brad are both fixed in my GitHub repo [2]. I haven't sent the fixed version to the list, though; let me know if I should.

Michael

[1] http://article.gmane.org/gmane.comp.version-control.git/245205 [2] Branch "ref-transactions" at https://github.com/mhagger/git

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/