From: Torsten Bögershausen <tboegi@web.de>
Date: Sat, 01 Mar 2014 15:50:44 GMT
Subject: Re: [PATCH v4 13/27] git-stash: avoid hardcoding $GIT_DIR/logs/....
Message-ID: <531201D4.6090900@web.de>
In-Reply-To: <1393675983-3232-14-git-send-email-pclouds@gmail.com>

On 2014-03-01 13.12, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  git-stash.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/git-stash.sh b/git-stash.sh
> index ae7d16e..12d9b37 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -183,7 +183,7 @@ store_stash () {
>  	fi
>  
>  	# Make sure the reflog for stash is kept.
> -	: >>"$GIT_DIR/logs/$ref_stash"
> +	: >>"`git rev-parse --git-path logs/$ref_stash`"
            "$(git rev-parse --git-path logs/$ref_stash)"
Shouldn't we prefer $() over `` ?