Re: [PATCH v5 00/31] Follow perlcritic's recommandations

From: Célestin Matte <celestin.matte@ensimag.fr>
Date: Jun 12, 2013, 20:34 UTC
Message-ID: <51B8DB5E.8030707@ensimag.fr>
In-Reply-To: <vpqd2rrqeqg.fsf@anie.imag.fr>

Le 12/06/2013 22:02, Matthieu Moy a écrit :

Show 8 quoted lines

> Célestin Matte <celestin.matte@ensimag.fr> writes:
> 
>> Not many changes since v3. This version is only for fixing last typos and
>> applying Junio's recommandations for [21/31], which I forgot in v4.
>> At this point, the only patch worth reviewing is [21/31].
> 
> Thanks. I went through the series again and it all looks good.
>

Actually, there still is a problem: the "defined(@array)" (introduced with the change in [21/31]) produces a warning. Benoit also seems to have problems with this patch... I'm waiting for his feedback.

-- 
Célestin Matte

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.