Re: [PATCH v5 00/31] Follow perlcritic's recommandations

From: Célestin Matte <celestin.matte@ensimag.fr>
Date: Jun 12, 2013, 20:47 UTC
Message-ID: <51B8DE57.9040205@ensimag.fr>
In-Reply-To: <51B8DB5E.8030707@ensimag.fr>

Le 12/06/2013 22:34, Célestin Matte a écrit :

Show 15 quoted lines

> Le 12/06/2013 22:02, Matthieu Moy a écrit :
>> Célestin Matte <celestin.matte@ensimag.fr> writes:
>>
>>> Not many changes since v3. This version is only for fixing last typos and
>>> applying Junio's recommandations for [21/31], which I forgot in v4.
>>> At this point, the only patch worth reviewing is [21/31].
>>
>> Thanks. I went through the series again and it all looks good.
>>
> 
> Actually, there still is a problem: the "defined(@array)" (introduced
> with the change in [21/31]) produces a warning.
> Benoit also seems to have problems with this patch... I'm waiting for
> his feedback.
>

There is indeed a bug. In patch [21/31], at line 163, it should be if (!defined $cmd[0]) { instead of if (!defined @cmd) { .

Should I send yet another version of this series of patch?

-- 
Célestin Matte