git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 12, 2013, 22:53 UTC
Message-ID
<7vobbbym7s.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpqr4g7owyi.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 9 quoted lines
> Which commit is this based on?
>
> "git am" fails, whether I try from Junio's master, next or pu. My best
> try was from da608b124c76f8f7dba8a9d8f0bc8174b9744176. It seems you're
> based on a local commit which doesn't exist on Junio's end.
>
> Most commit in-flight are in next, so I guess rebasing the series on
> next would make it easier for Junio (we normally send patches against
> master as much as possible, see SubmittingPatches for more details).

This is why a wholesale updates like "use sq instead of dq when we can", "always return; from a sub", etc. needs inter-developer coordination.

I agree with you that it would probably be the easiest to build this on top of the merge bewteen master, bp/mediawiki-credential, and your mm/mediawiki-https-fail-message topics.

Thanks.
Previous: Célestin Matte
Message 39 of 39 in “Follow perlcritic's recommandations”
  1. 00/31 Follow perlcritic's recommandationsCélestin Matte, Jun 12, 2013
  2. 01/31 git-remote-mediawiki: Make a regexp clearerCélestin Matte, Jun 12, 2013
  3. 02/31 git-remote-mediawiki: Move "use warnings;" before any instructionCélestin Matte, Jun 12, 2013
  4. 03/31 git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8)Célestin Matte, Jun 12, 2013
  5. 04/31 git-remote-mediawiki: Always end a subroutine with a returnCélestin Matte, Jun 12, 2013
  6. 05/31 git-remote-mediawiki: Move a variable declaration at the top of the codeCélestin Matte, Jun 12, 2013
  7. 06/31 git-remote-mediawiki: Change syntax of map callsCélestin Matte, Jun 12, 2013
  8. 07/31 git-remote-mediawiki: Rewrite unclear line of instructionsCélestin Matte, Jun 12, 2013
  9. 08/31 git-remote-mediawiki: Remove useless regexp modifier (m)Célestin Matte, Jun 12, 2013
  10. 09/31 git-remote-mediawiki: Change the behaviour of a splitCélestin Matte, Jun 12, 2013
  11. 10/31 git-remote-mediawiki: Change separator of some regexpsCélestin Matte, Jun 12, 2013
  12. 11/31 git-remote-mediawiki: Change style in a regexpCélestin Matte, Jun 12, 2013
  13. 12/31 git-remote-mediawiki: Change style in a regexpCélestin Matte, Jun 12, 2013
  14. 13/31 git-remote-mediawiki: Add newline in the end of die() error messagesCélestin Matte, Jun 12, 2013
  15. 14/31 git-remote-mediawiki: Change the name of a variableCélestin Matte, Jun 12, 2013
  16. 15/31 git-remote-mediawiki: Turn double-negated expressions into simple expressionsCélestin Matte, Jun 12, 2013
  17. 16/31 git-remote-mediawiki: Remove unused variable $entryCélestin Matte, Jun 12, 2013
  18. 17/31 git-remote-mediawiki: Rename a variable ($last) which has the name of a keywordCélestin Matte, Jun 12, 2013
  19. 18/31 git-remote-mediawiki: Assign a variable as undef and make proper indentationCélestin Matte, Jun 12, 2013
  20. 19/31 git-remote-mediawiki: Check return value of openCélestin Matte, Jun 12, 2013
  21. 20/31 git-remote-mediawiki: remove import of unused open2Célestin Matte, Jun 12, 2013
  22. 21/31 git-remote-mediawiki: Put long code into a subroutineCélestin Matte, Jun 12, 2013
  23. 22/31 git-remote-mediawiki: Modify strings for a better coding-styleCélestin Matte, Jun 12, 2013
  24. 23/31 git-remote-mediawiki: Brace file handles for print for more clarityCélestin Matte, Jun 12, 2013
  25. 24/31 git-remote-mediawiki: Replace "unless" statements with negated "if" statementsCélestin Matte, Jun 12, 2013
  26. 25/31 git-remote-mediawiki: Don't use quotes for empty stringsCélestin Matte, Jun 12, 2013
  27. 26/31 git-remote-mediawiki: Put non-trivial numeric values in constants.Célestin Matte, Jun 12, 2013
  28. 27/31 git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki")Célestin Matte, Jun 12, 2013
  29. 28/31 git-remote-mediawiki: Clearly rewrite double dereferenceCélestin Matte, Jun 12, 2013
  30. 29/31 git-remote-mediawiki: Add a .perlcriticrc fileCélestin Matte, Jun 12, 2013
  31. 30/31 git-remote-mediawiki: add a perlcritic rule in MakefileCélestin Matte, Jun 12, 2013
  32. 31/31 git-remote-mediawiki: Make error message more preciseCélestin Matte, Jun 12, 2013
  33. Matthieu MoyJun 12, 2013
  34. Célestin MatteJun 12, 2013
  35. Célestin MatteJun 12, 2013
  36. Eric SunshineJun 12, 2013
  37. Matthieu MoyJun 12, 2013
  38. Célestin MatteJun 12, 2013
  39. Junio C HamanoJun 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.