From: Célestin Matte Date: Wed, 12 Jun 2013 20:34:38 GMT Subject: Re: [PATCH v5 00/31] Follow perlcritic's recommandations Message-ID: <51B8DB5E.8030707@ensimag.fr> In-Reply-To: Le 12/06/2013 22:02, Matthieu Moy a écrit : > Célestin Matte writes: > >> Not many changes since v3. This version is only for fixing last typos and >> applying Junio's recommandations for [21/31], which I forgot in v4. >> At this point, the only patch worth reviewing is [21/31]. > > Thanks. I went through the series again and it all looks good. > Actually, there still is a problem: the "defined(@array)" (introduced with the change in [21/31]) produces a warning. Benoit also seems to have problems with this patch... I'm waiting for his feedback. -- Célestin Matte