Re: [PATCH 3/6] t6601: add helper for testing path-walk API

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 8, 2024, 14:53 UTC
Message-ID: <5085b96d-4757-4ace-9610-baa21c05bf4d@gmail.com>
In-Reply-To: <20241104233912.2493936-1-jonathantanmy@google.com>

On 11/4/24 6:39 PM, Jonathan Tan wrote:

Show 10 quoted lines

> Derrick Stolee <stolee@gmail.com> writes:
> 
>> The biggest question I'd like to ask is this: do you see a risk of
>> a path being repeated? There are cases where it will happen, such as
>> indexed objects that are not reachable anywhere else.
> 
> I was thinking that the whole point of this feature is that we group
> objects by path, so it seems desirable to test that paths are not
> repeated. (Or repeated as little as possible, if it is not possible
> to avoid repetition e.g. in the case you describe.)

In addition to determining the order of the batches, it can be helpful to demonstrate that we don't call the path_fn with an empty batch! I discovered this while making the appropriate changes today and putting the fixes in the right places.

Thanks, -Stolee