git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jan 22, 2010, 19:40 UTC
Message-ID
<4B59FF3A.5080502@ramsay1.demon.co.uk>
In-Reply-To
<4B5789AD.2080807@gmail.com>
Sebastian Schuberth wrote:
Show 13 quoted lines
> On 20.01.2010 20:23, Ramsay Jones wrote:
> 
>  > '-o' or connective. This resulted in the buildsystem generator
>  > mistaking the conditional 'rm' for a linker command. In order
> 
> Thanks for spotting the cause of this! Some comments:
> 
> 1. How about deleting lines 183-185 in same run? That commented out 
> code, too, is missing the escapes for the pipes that Pete mentioned anyway.
> 
> -#        } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
> -#            # commands removing executables, if they exist
> -#
OK, will do.
Show 8 quoted lines
> 
> 2. Couldn't we reduce the test to just
> 
> +        if ($text =~ /^test /) {
> +            # options to test may be mistaken for linker options
> +            next;
> +        }
> +
Yes, good idea.  I will send a new version of the patch soon.
Thanks!

ATB, Ramsay Jones

Previous: Sebastian Schuberth
Message 5 of 5 in “engine.pl: Fix a recent breakage of the buildsystem generator”
  1. 1/4 engine.pl: Fix a recent breakage of the buildsystem generatorRamsay Jones, Jan 20, 2010
  2. Pete HarlanJan 20, 2010
  3. Ramsay JonesJan 22, 2010
  4. Sebastian SchuberthJan 20, 2010
  5. Ramsay JonesJan 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.