From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Fri, 22 Jan 2010 19:40:42 GMT
Subject: Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator
Message-ID: <4B59FF3A.5080502@ramsay1.demon.co.uk>
In-Reply-To: <4B5789AD.2080807@gmail.com>

Sebastian Schuberth wrote:
> On 20.01.2010 20:23, Ramsay Jones wrote:
> 
>  > '-o' or connective. This resulted in the buildsystem generator
>  > mistaking the conditional 'rm' for a linker command. In order
> 
> Thanks for spotting the cause of this! Some comments:
> 
> 1. How about deleting lines 183-185 in same run? That commented out 
> code, too, is missing the escapes for the pipes that Pete mentioned anyway.
> 
> -#        } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
> -#            # commands removing executables, if they exist
> -#

OK, will do.

> 
> 2. Couldn't we reduce the test to just
> 
> +        if ($text =~ /^test /) {
> +            # options to test may be mistaken for linker options
> +            next;
> +        }
> +

Yes, good idea.  I will send a new version of the patch soon.

Thanks!

ATB,
Ramsay Jones