Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Jan 22, 2010, 18:58 UTC
Message-ID: <4B59F549.8070308@ramsay1.demon.co.uk>
In-Reply-To: <4B576E38.5080604@pcharlan.com>

Pete Harlan wrote:

Show 12 quoted lines

> On 01/20/2010 11:23 AM, Ramsay Jones wrote:
>> diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
>> index d506717..245af73 100644
>> --- a/contrib/buildsystems/engine.pl
>> +++ b/contrib/buildsystems/engine.pl
>> @@ -135,6 +135,11 @@ sub parseMakeOutput
>>              }
>>          } while($ate_next);
>>  
>> +        if ($text =~ /^test / && $text =~ /|| rm -f /) {
> 
> That test on the right needs to escape its pipes or it will always match.

Heh, well spotted! As you may have already noticed, I copy/pasted the code from the comment further down in this function, but didn't take enough care in doing so... Oops! ;-)

The obvious solution, also suggested later by Sebastion, is to simply remove the second regex from the test since it does not alter the outcome (and still fixes the problem)...

ATB, Ramsay Jones