git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Jan 20, 2010, 19:23 UTC
Message-ID
<4B575838.2010504@ramsay1.demon.co.uk>

Commit ade2ca0c (Do not try to remove directories when removing old links, 27-10-2009) added an expression to a 'test' using an '-o' or connective. This resulted in the buildsystem generator mistaking the conditional 'rm' for a linker command. In order to fix the breakage, we filter the out the conditional 'rm' commands before attempting to identify other commands.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 contrib/buildsystems/engine.pl |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
index d506717..245af73 100644
--- a/contrib/buildsystems/engine.pl
+++ b/contrib/buildsystems/engine.pl
@@ -135,6 +135,11 @@ sub parseMakeOutput
             }
         } while($ate_next);
 
+        if ($text =~ /^test / && $text =~ /|| rm -f /) {
+            # commands removing executables, if they exist
+            next;
+        }
+
         if($text =~ / -c /) {
             # compilation
             handleCompileLine($text, $line);
-- 
1.6.6
Next: Pete Harlan
Message 1 of 5 in “engine.pl: Fix a recent breakage of the buildsystem generator”
  1. 1/4 engine.pl: Fix a recent breakage of the buildsystem generatorRamsay Jones, Jan 20, 2010
  2. Pete HarlanJan 20, 2010
  3. Ramsay JonesJan 22, 2010
  4. Sebastian SchuberthJan 20, 2010
  5. Ramsay JonesJan 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.