git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator

From
PHPete Harlan <pgit@pcharlan.com>
Date
Jan 20, 2010, 20:57 UTC
Message-ID
<4B576E38.5080604@pcharlan.com>
In-Reply-To
<4B575838.2010504@ramsay1.demon.co.uk>
On 01/20/2010 11:23 AM, Ramsay Jones wrote:
Show 9 quoted lines
> diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
> index d506717..245af73 100644
> --- a/contrib/buildsystems/engine.pl
> +++ b/contrib/buildsystems/engine.pl
> @@ -135,6 +135,11 @@ sub parseMakeOutput
>              }
>          } while($ate_next);
>  
> +        if ($text =~ /^test / && $text =~ /|| rm -f /) {
That test on the right needs to escape its pipes or it will always match.
--Pete
Show 7 quoted lines
> +            # commands removing executables, if they exist
> +            next;
> +        }
> +
>          if($text =~ / -c /) {
>              # compilation
>              handleCompileLine($text, $line);
Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 5 in “engine.pl: Fix a recent breakage of the buildsystem generator”
  1. 1/4 engine.pl: Fix a recent breakage of the buildsystem generatorRamsay Jones, Jan 20, 2010
  2. Pete HarlanJan 20, 2010
  3. Ramsay JonesJan 22, 2010
  4. Sebastian SchuberthJan 20, 2010
  5. Ramsay JonesJan 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.