git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters

From
TTTommy Thorn <tommy-git@thorn.ws>
Date
May 17, 2008, 00:06 UTC
Message-ID
<482E2175.8030904@thorn.ws>
In-Reply-To
<alpine.DEB.1.00.0805170058160.30431@racer>
Johannes Schindelin wrote:
Show 7 quoted lines
> +/*
> + *  This is an ugly hack to avoid fgetc(), which is slow, as it is locking.
> + *  The argument "in" must be the same for all calls to this function!
> + */
> +static int fast_fgetc(FILE *in)
> +{
>

Looks great to me, but shouldn't you add an "inline" for this one? Also, maybe a double the buffer size.

Tommy
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 10 of 21 in “git bug: rebase fatal failure”
  1. Tommy ThornMay 15, 2008
  2. Johannes SchindelinMay 16, 2008
  3. Johannes SchindelinMay 16, 2008
  4. mailsplit and mailinfo: gracefully handle NUL charactersJohannes Schindelin, May 16, 2008
  5. Avery PennarunMay 16, 2008
  6. David KastrupMay 16, 2008
  7. Johannes SchindelinMay 16, 2008
  8. Avery PennarunMay 16, 2008
  9. Johannes SchindelinMay 16, 2008
  10. Tommy ThornMay 17, 2008
  11. Johannes SchindelinMay 17, 2008
  12. Stephen R. van den BergMay 17, 2008
  13. Johannes SchindelinMay 17, 2008
  14. Junio C HamanoMay 21, 2008
  15. Johannes SchindelinMay 22, 2008
  16. Junio C HamanoMay 22, 2008
  17. Johannes SchindelinMay 23, 2008
  18. Brian FosterMay 16, 2008
  19. David KastrupMay 16, 2008
  20. Johannes SchindelinMay 16, 2008
  21. David KastrupMay 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.