From: Tommy Thorn Date: Sat, 17 May 2008 00:06:13 GMT Subject: Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters Message-ID: <482E2175.8030904@thorn.ws> In-Reply-To: Johannes Schindelin wrote: > +/* > + * This is an ugly hack to avoid fgetc(), which is slow, as it is locking. > + * The argument "in" must be the same for all calls to this function! > + */ > +static int fast_fgetc(FILE *in) > +{ > Looks great to me, but shouldn't you add an "inline" for this one? Also, maybe a double the buffer size. Tommy