git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 17, 2008, 10:18 UTC
Message-ID
<alpine.DEB.1.00.0805171117010.30431@racer>
In-Reply-To
<20080517100726.GA24416@cuci.nl>
Hi,
On Sat, 17 May 2008, Stephen R. van den Berg wrote:
Show 11 quoted lines
> Johannes Schindelin wrote:
> >On Fri, 16 May 2008, Avery Pennarun wrote:
> >> fread is about 18x faster than fgetc().  getc() is the same speed as
> >> fgetc().  getc_unlocked() is definitely faster than getc, but still at
> >> least 7x slower than fread().
> 
> >Well, my question was more about fgetc() vs fgets().
> >If you feel like it, you might benchmark this patch:
> 
> Wouldn't it be better to improve the implementation of getc()
> in glibc instead?
Sure, because glibc is used on Windows, AIX, Solaris, etc.
> getc() is meant to be the fast version of fgetc(), and if it isn't 
> (anymore), then the library needs fixing.

fgetc() has to work reliably in a threaded environment, too. So I guess that it does all kinds of locks that slow it down, but it is not something to be "fixed".

Hth, Dscho

Previous: Stephen R. van den BergNext: Junio C Hamano
Message 13 of 21 in “git bug: rebase fatal failure”
  1. Tommy ThornMay 15, 2008
  2. Johannes SchindelinMay 16, 2008
  3. Johannes SchindelinMay 16, 2008
  4. mailsplit and mailinfo: gracefully handle NUL charactersJohannes Schindelin, May 16, 2008
  5. Avery PennarunMay 16, 2008
  6. David KastrupMay 16, 2008
  7. Johannes SchindelinMay 16, 2008
  8. Avery PennarunMay 16, 2008
  9. Johannes SchindelinMay 16, 2008
  10. Tommy ThornMay 17, 2008
  11. Johannes SchindelinMay 17, 2008
  12. Stephen R. van den BergMay 17, 2008
  13. Johannes SchindelinMay 17, 2008
  14. Junio C HamanoMay 21, 2008
  15. Johannes SchindelinMay 22, 2008
  16. Junio C HamanoMay 22, 2008
  17. Johannes SchindelinMay 23, 2008
  18. Brian FosterMay 16, 2008
  19. David KastrupMay 16, 2008
  20. Johannes SchindelinMay 16, 2008
  21. David KastrupMay 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.