Re: [PATCH] mailsplit and mailinfo: gracefully handle NUL characters

From: Stephen R. van den Berg <srb@cuci.nl>
Date: May 17, 2008, 10:07 UTC
Message-ID: <20080517100726.GA24416@cuci.nl>
In-Reply-To: <alpine.DEB.1.00.0805170058160.30431@racer>

Johannes Schindelin wrote:

>On Fri, 16 May 2008, Avery Pennarun wrote:
>> fread is about 18x faster than fgetc().  getc() is the same speed as
>> fgetc().  getc_unlocked() is definitely faster than getc, but still at
>> least 7x slower than fread().

>Well, my question was more about fgetc() vs fgets().
>If you feel like it, you might benchmark this patch:

Wouldn't it be better to improve the implementation of getc() in glibc instead?

getc() is meant to be the fast version of fgetc(), and if it isn't (anymore), then the library needs fixing.

-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg.