git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Reporting bugs and bisection

From
RHRene Herman <rene.herman@keyaccess.nl>
Date
Apr 14, 2008, 22:18 UTC
Message-ID
<4803D830.7000206@keyaccess.nl>
In-Reply-To
<20080414133802.4535e4da.akpm@linux-foundation.org>
On 14-04-08 22:38, Andrew Morton wrote:
Show 7 quoted lines
> On Mon, 14 Apr 2008 21:13:41 +0200
> Rene Herman <rene.herman@keyaccess.nl> wrote:
> 
>> Does that mean you're not going to take patches that align the right end of 
>> lines in comments? :-(
> 
> erm, was that ":-(" supposed to be a ":-)"?

The ":-(" was supposed to add to the implicitly obvious ":-)". That is, was indeed joking (Al mentioned them) but with a slightly serious undertone:

Show 7 quoted lines
> I don't like to merge patches which fix typos and spellos and grammaros 
> in comments, simply because I'd be buried in the things. I do take such 
> fixes for user-visible text (Documentation/, kerneldoc comments and 
> printks).
> 
> Right-justification of comments would fall rather a long way below
> spelling fixes.

You, particularly, seem to be very good at picking up trivia. I've posted completely trivial patches from time to time for small things I encounter while looking at something else. Things at the "are people going to look funny at me for even bothering or..." level but you picking them up means it's still useful to post, so I sometimes do.

Now, in fact, Linux as a _whole_ doesn't seem bad at accepting that kind of small janitorial stuff but I have been noticing some backlash to it as well. I'm not sure it's worse or better than historically, but the "checkpatch syndrome" certainly triggers more of it.

Al specifically wanted more new eyes but the way to reward those new eyes is accepting their small changes. Al also specifically doesn't like those small changes when at the level of the automated and semi-brainless checkpatch level.

I believe the janitorial work has been over-organized, both through the kernel-janitors and checkpatch since while these are very useful in guiding a newbie in _what_ to do they cause "automated" huge tree-wide trivia storms which people then don't react overly favourable to and the new eyes who did all that work of generating it all dim again...

Frankly, the kernel really is fairly complex these days when starting at 0. Much more complex certainly than, say, back in 2.0 or 2.2 days and while Al's scenario of per-subsystem reviews might be good, I don't believe it's very realistic. Companies don't pay to have those done and for newbies it's generally too complex since understanding most parts of the kernel fully, requires understanding most of the rest kernel rather well also.

So you get the really promising newbies? Yeah, that, or you don't get anyone and if some promising newbies are building up 137 part checkpatch inspired patchsets that don't help none.

So, what am I saying (what _am_ I saying?!?) ...

I seemed to observe somewhat of an internal contradiction in Al's message about new eyes and his dislike of the trivial stuff but the contradiction only exists if the dislike wouldn't be limited to these kinds of huge trivia storms. I believe it is, and I furthermore believe that yes, it's over-organization that causes many new eyes to focus on the brainless aspects.

Now, do those new eyes have many other options when very few (to none) of the core crowd ever does things like answer question on the kernelnewbies list? From the established names, I only remember ever seeing Greg KH and Adrian Bunk there. And I'm _still_ pissed that noone would or could tell me what was wrong with the legacy CD-ROM driver I and Pekka Enberg were toying around with a while ago. Frankly, I care a whole lot less about a hundred sparse warning fixes.

In short -- the kernel in it's current state is already quite complex and if new eyes are wanted they'll need to be coached more. I'm seeing very little of that.

Rene.
Previous: Andrew Morton
Message 66 of 66 in “Re: Reporting bugs and bisection”
  1. david@lang.hmApr 13, 2008
  2. Jakub NarebskiApr 14, 2008
  3. Willy TarreauApr 14, 2008
  4. Al ViroApr 14, 2008
  5. Andrew MortonApr 14, 2008
  6. David MillerApr 14, 2008
  7. David MillerApr 14, 2008
  8. Al ViroApr 14, 2008
  9. Al ViroApr 14, 2008
  10. Andrew MortonApr 14, 2008
  11. David MillerApr 14, 2008
  12. Christoph HellwigApr 14, 2008
  13. Andi KleenApr 14, 2008
  14. Bill FinkApr 15, 2008
  15. Andrew MortonApr 14, 2008
  16. David MillerApr 14, 2008
  17. Roman ShaposhnikApr 14, 2008
  18. Adrian BunkApr 14, 2008
  19. Arjan van de VenApr 14, 2008
  20. Andrew MortonApr 14, 2008
  21. Arjan van de VenApr 14, 2008
  22. Ilpo JärvinenApr 14, 2008
  23. James MorrisApr 14, 2008
  24. David MillerApr 14, 2008
  25. Andrew MortonApr 14, 2008
  26. Willy TarreauApr 15, 2008
  27. Work WAS(Re: Reporting bugs and bisectionjamal, Apr 15, 2008
  28. David NewallApr 15, 2008
  29. Michael KerriskApr 15, 2008
  30. David NewallApr 15, 2008
  31. Rafael J. WysockiApr 15, 2008
  32. David NewallApr 16, 2008
  33. david@lang.hmApr 16, 2008
  34. David NewallApr 16, 2008
  35. Andi KleenApr 16, 2008
  36. Stephen ClarkApr 16, 2008
  37. Willy TarreauApr 16, 2008
  38. Rafael J. WysockiApr 16, 2008
  39. Sverre RabbelierApr 16, 2008
  40. Adrian BunkApr 16, 2008
  41. Andrew MortonApr 16, 2008
  42. Sverre RabbelierApr 16, 2008
  43. Adrian BunkApr 16, 2008
  44. J. Bruce FieldsApr 17, 2008
  45. Adrian BunkApr 17, 2008
  46. Alexey DobriyanApr 16, 2008
  47. Arjan van de VenApr 16, 2008
  48. Sverre RabbelierApr 16, 2008
  49. Adrian BunkApr 16, 2008
  50. Adrian BunkApr 16, 2008
  51. Sverre RabbelierApr 16, 2008
  52. Adrian BunkApr 16, 2008
  53. Willy TarreauApr 16, 2008
  54. Jakub NarebskiApr 16, 2008
  55. Jesper JuhlApr 16, 2008
  56. David NewallApr 17, 2008
  57. Rafael J. WysockiApr 17, 2008
  58. Ray LeeApr 17, 2008
  59. Sverre RabbelierApr 17, 2008
  60. Al ViroApr 17, 2008
  61. Ray LeeApr 17, 2008
  62. Al ViroApr 17, 2008
  63. Ray LeeApr 17, 2008
  64. Rene HermanApr 14, 2008
  65. Andrew MortonApr 14, 2008
  66. Rene HermanApr 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.