Re: [PATCH 1/4] midx repack: avoid integer overflow on 32 bit systems

From: Phillip Wood <phillip.wood123@gmail.com>
Date: May 21, 2025, 15:20 UTC
Message-ID: <46161e73-f875-4d9d-a344-94dca2a7b01a@gmail.com>
In-Reply-To: <CALnO6CAMqVvHbY2sR_+dt8vYHxDn4S7f4B2jq+HcMEXx7SLj9Q@mail.gmail.com>

Hi Ben

On 21/05/2025 14:10, D. Ben Knoble wrote:

Show 5 quoted lines

> On Tue, May 20, 2025 at 11:05 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>> +               if (unsigned_add_overflows (total_size, (size_t)expected_size))
> 
> Style nit (only in case Taylor's approach doesn't prove better): I
> wasn't expecting a space between the function and its argument list.

Good catch, I'll fix that

Thanks

Phillip

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.