From: Phillip Wood Date: Wed, 21 May 2025 15:20:49 GMT Subject: Re: [PATCH 1/4] midx repack: avoid integer overflow on 32 bit systems Message-ID: <46161e73-f875-4d9d-a344-94dca2a7b01a@gmail.com> In-Reply-To: Hi Ben On 21/05/2025 14:10, D. Ben Knoble wrote: > On Tue, May 20, 2025 at 11:05 AM Phillip Wood wrote: >> + if (unsigned_add_overflows (total_size, (size_t)expected_size)) > > Style nit (only in case Taylor's approach doesn't prove better): I > wasn't expecting a space between the function and its argument list. Good catch, I'll fix that Thanks Phillip