Re: [PATCH 1/4] midx repack: avoid integer overflow on 32 bit systems

From

Junio C Hamano <gitster@pobox.com>

Date

May 21, 2025, 15:01 UTC

Message-ID

<xmqqh61ec8j7.fsf@gitster.g>

In-Reply-To

<CALnO6CAMqVvHbY2sR_+dt8vYHxDn4S7f4B2jq+HcMEXx7SLj9Q@mail.gmail.com>

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

>> +               if (unsigned_add_overflows (total_size, (size_t)expected_size))
>
> Style nit (only in case Taylor's approach doesn't prove better): I
> wasn't expecting a space between the function and its argument list.

Good eyes.  I didn't notice it myself.