git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] midx repack: fix overflow on 32 bit systems

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
May 20, 2025, 15:04 UTC
Message-ID
<cover.1747753388.git.phillip.wood@dunelm.org.uk>
From: Phillip Wood <phillip.wood@dunelm.org.uk>

This series fixes an overflow when running "git multi-pack-index repack" on an old raspberry pi and a couple of other small issues I noticed while reading the code. I'm unsure how realistic the example of integer overflow on 64 bit systems in patch 2 is. I'm happy to drop it if people who work with large repositories think its not worth worrying about.

Base-Commit: cb96e1697ad6e54d11fc920c95f82977f8e438f8
Published-As: https://github.com/phillipwood/git/releases/tag/pw%2Fmidx-repack-overflow%2Fv1
View-Changes-At: https://github.com/phillipwood/git/compare/cb96e1697...29769df1c
Fetch-It-Via: git fetch https://github.com/phillipwood/git pw/midx-repack-overflow/v1
Phillip Wood (4):
  midx repack: avoid integer overflow on 32 bit systems
  midx repack: avoid potential integer overflow on 64 bit systems
  midx: avoid negative array index
  midx docs: clarify tie breaking
 Documentation/git-multi-pack-index.adoc |  6 ++++--
 git-compat-util.h                       | 16 ++++++++++++++++
 midx-write.c                            | 22 ++++++++++++++++------
 3 files changed, 36 insertions(+), 8 deletions(-)
-- 
2.49.0.897.gfad3eb7d210
Next: Phillip Wood
Message 1 of 25 in “midx repack: fix overflow on 32 bit systems”
  1. 0/4 midx repack: fix overflow on 32 bit systemsPhillip Wood, May 20, 2025
  2. 1/4 midx repack: avoid integer overflow on 32 bit systemsPhillip Wood, May 20, 2025
  3. Taylor BlauMay 20, 2025
  4. Phillip WoodMay 21, 2025
  5. Taylor BlauMay 23, 2025
  6. D. Ben KnobleMay 21, 2025
  7. Junio C HamanoMay 21, 2025
  8. Phillip WoodMay 21, 2025
  9. 2/4 midx repack: avoid potential integer overflow on 64 bit systemsPhillip Wood, May 20, 2025
  10. Taylor BlauMay 20, 2025
  11. Phillip WoodMay 21, 2025
  12. 3/4 midx: avoid negative array indexPhillip Wood, May 20, 2025
  13. Taylor BlauMay 20, 2025
  14. 4/4 midx docs: clarify tie breakingPhillip Wood, May 20, 2025
  15. Taylor BlauMay 20, 2025
  16. Phillip WoodMay 21, 2025
  17. D. Ben KnobleMay 21, 2025
  18. 0/4 midx repack: fix overflow on 32 bit systemsPhillip Wood, May 22, 2025
  19. 2/4 midx repack: avoid potential integer overflow on 64 bit systemsPhillip Wood, May 22, 2025
  20. 1/4 midx repack: avoid integer overflow on 32 bit systemsPhillip Wood, May 22, 2025
  21. 3/4 midx: avoid negative array indexPhillip Wood, May 22, 2025
  22. 4/4 midx docs: clarify tie breakingPhillip Wood, May 22, 2025
  23. Taylor BlauMay 23, 2025
  24. Phillip WoodMay 27, 2025
  25. Junio C HamanoMay 27, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.