Re: [PATCH v8 0/3] maintenance: add support for systemd timers on Linux

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 24, 2021, 17:47 UTC
Message-ID: <44904983-a6a8-d72f-24db-50bf112c585b@gmail.com>
In-Reply-To: <20210823204011.87023-1-lenaic@lhuard.fr>

On 8/23/2021 4:40 PM, Lénaïc Huard wrote:

Show 8 quoted lines

> According to [1], there were 3 changes awaited in this v8:
> * The two already mentionned above (utf-8 characters and
>   `string_list_split` thing)
> * An improvement around the #ifdef.
> 
> I must admit I haven’t touched anything around the #ifdef in this v8
> because I’m not sure what to do. I’ve just asked for some more details
> in [2].

I commented on the relevant patches, but in summary:

1. I think your #ifdef __APPLE__ is fine in patch 2.

2. The #ifdef __linux__ in patch 3 could be removed
   entirely.

Then there is a nit about whitespace, but that is easily rectified with 'git rebase --whitespace=fix'.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.