From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 24 Aug 2021 17:47:44 GMT
Subject: Re: [PATCH v8 0/3] maintenance: add support for systemd timers on Linux
Message-ID: <44904983-a6a8-d72f-24db-50bf112c585b@gmail.com>
In-Reply-To: <20210823204011.87023-1-lenaic@lhuard.fr>

On 8/23/2021 4:40 PM, Lénaïc Huard wrote:
> According to [1], there were 3 changes awaited in this v8:
> * The two already mentionned above (utf-8 characters and
>   `string_list_split` thing)
> * An improvement around the #ifdef.
> 
> I must admit I haven’t touched anything around the #ifdef in this v8
> because I’m not sure what to do. I’ve just asked for some more details
> in [2].

I commented on the relevant patches, but in summary:

1. I think your #ifdef __APPLE__ is fine in patch 2.

2. The #ifdef __linux__ in patch 3 could be removed
   entirely.

Then there is a nit about whitespace, but that is easily
rectified with 'git rebase --whitespace=fix'.

Thanks,
-Stolee