Re: [PATCH v7 2/3] maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 13, 2021, 02:22 UTC
- Message-ID
- <CAPig+cT-x4_YuxmmoFw62jFqKRFJrS_UkyNOkdQz9-Gwec3QCQ@mail.gmail.com>
- In-Reply-To
- <YOzbO1/mfL8hKhBT@coredump.intra.peff.net>
On Mon, Jul 12, 2021 at 8:16 PM Jeff King <peff@peff.net> wrote:
Show 12 quoted lines
> On Tue, Jul 06, 2021 at 01:52:12PM -0700, Junio C Hamano wrote: > > A helper function that takes a string and returns a strvec would be > > a good fit, though. > > I was going to second that, but I see we already have one. :) Dscho > introduced it in c5aa6db64f (argv_array: offer to split a string by > whitespace, 2018-04-25), and then it later became strvec_split(). > > And indeed, Lénaïc's patches use it elsewhere. I think it doesn't work > in this instance because it can't take an arbitrary delimiter. But I > wouldn't at all mind seeing it grow that feature (and I suspect it could > even share some code with string_list_split(), but didn't look).
Since Lénaïc is a relative newcomer to the project, can we, as reviewers, be clear that we don't expect him to perform the task of generalizing strvec_split() just to get this series -- which is already at v7 -- landed? I gave the previous round a pretty thorough going-over and -- aside from one minor test-time bug -- didn't find any show-stoppers which should prevent it from landing. While it may be the case that the series has a superficial wart here and there (such as #ifdef's in function bodies, and non-ASCII fancy comment boxes), the review comments on the latest round have pretty much all been subjective; I haven't seen any outright actionable observations. Extra polishing based upon the subjective review comments can always be done later atop Lénaïc's series (if someone -- not necessarily Lénaïc -- wants to do so) without asking him for endless re-rolls.