Re: [PATCH v7 2/3] maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Jul 13, 2021, 07:04 UTC
- Message-ID
- <80ad532f-bcbe-2af2-27e3-0f503209b300@gmail.com>
- In-Reply-To
- <CAPig+cT-x4_YuxmmoFw62jFqKRFJrS_UkyNOkdQz9-Gwec3QCQ@mail.gmail.com>
On 13/07/21 09.22, Eric Sunshine wrote:
Show 14 quoted lines
> Since Lénaïc is a relative newcomer to the project, can we, as > reviewers, be clear that we don't expect him to perform the task of > generalizing strvec_split() just to get this series -- which is > already at v7 -- landed? I gave the previous round a pretty thorough > going-over and -- aside from one minor test-time bug -- didn't find > any show-stoppers which should prevent it from landing. While it may > be the case that the series has a superficial wart here and there > (such as #ifdef's in function bodies, and non-ASCII fancy comment > boxes), the review comments on the latest round have pretty much all > been subjective; I haven't seen any outright actionable observations. > Extra polishing based upon the subjective review comments can always > be done later atop Lénaïc's series (if someone -- not necessarily > Lénaïc -- wants to do so) without asking him for endless re-rolls. >
In such situation when there is endless re-roll of patch series due to subjective reviews, we can ask for final call from the maintainer, right?
-- An old man doll... just what I always wanted! - Clara