Re: git-send-email generates mail with invalid Message-Id
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Jul 28, 2009, 09:51 UTC
- Message-ID
- <40aa078e0907280251k159d9a93xa8c90413b3fab5a@mail.gmail.com>
- In-Reply-To
- <200907281127.44558.trast@student.ethz.ch>
On Tue, Jul 28, 2009 at 11:27 AM, Thomas Rast<trast@student.ethz.ch> wrote:
Show 15 quoted lines
> Erik Faye-Lund wrote: >> On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@planet.nl> wrote: >> > I assume that this is a configuration issue in the git setup of the >> > sender, but shouldn't git-send-email refuse to send out messages with an >> > invalid Message-Id? >> >> Not quite. git-send-email generates these message-ids itself (those >> who contain "-git-send-email-", that is), and should as such be able >> to rely on them being generated correctly. [...] >> I'm no perl-expert, but the code looks pretty much correct to me. > > git-format-patch generates its own message IDs if it needs them for > threading, with gen_message_id() (in builtin-log.c). That one appends > the committer email address blindly, without verifying that it has an > @ in it.
That must be a separate issue (but quite possibly a valid one), since gen_message_id's ids dont' contain "-send-email-" like the message-id in the report does, no?
-- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656