git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-send-email generates mail with invalid Message-Id

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Jul 28, 2009, 09:17 UTC
Message-ID
<40aa078e0907280217g76cbfai8544edde605f8772@mail.gmail.com>
In-Reply-To
<200907280446.22890.elendil@planet.nl>
On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@planet.nl> wrote:
> The problem is that a Message-Id is supposed (RFC 822) to end in a domain
> part (...@example.com), but that's missing.
Correct.
> I assume that this is a configuration issue in the git setup of the
> sender, but shouldn't git-send-email refuse to send out messages with an
> invalid Message-Id?

Not quite. git-send-email generates these message-ids itself (those who contain "-git-send-email-", that is), and should as such be able to rely on them being generated correctly. However, I'm a bit curious as to how these ends up incorrect in the first place. The code in make_message_id tries to append the sender's e-mail to timestamp+"-git-send-email-", if that fails it tries the comitter's e-mail, then the author's e-mail. As a last resort, it tries to append "user@"+hostname.

I'm no perl-expert, but the code looks pretty much correct to me.

The problematic e-mails, are they coming from another user than you? Can you find out who that is, and check what git-version he or she runs?

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Previous: Frans PopNext: Thomas Rast
Message 2 of 13 in “git-send-email generates mail with invalid Message-Id”
  1. Frans PopJul 28, 2009
  2. Erik Faye-LundJul 28, 2009
  3. Thomas RastJul 28, 2009
  4. Erik Faye-LundJul 28, 2009
  5. Thomas RastJul 28, 2009
  6. Frans PopJul 28, 2009
  7. Frans PopJul 28, 2009
  8. Nicolas SebrechtJul 28, 2009
  9. Frans PopJul 28, 2009
  10. Nicolas SebrechtJul 28, 2009
  11. Erik Faye-LundJul 28, 2009
  12. Erik Faye-LundJul 28, 2009
  13. Nicolas SebrechtJul 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.