Re: git-send-email generates mail with invalid Message-Id

From: Frans Pop <elendil@planet.nl>
Date: Jul 28, 2009, 11:13 UTC
Message-ID: <200907281313.51304.elendil@planet.nl>
In-Reply-To: <20090728104423.GA12947@vidovic>

On Tuesday 28 July 2009, you wrote:

Show 9 quoted lines

> Erik Faye-Lund wrote:
> > On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@planet.nl> wrote:
> > > I assume that this is a configuration issue in the git setup of the
> > > sender, but shouldn't git-send-email refuse to send out messages
> > > with an invalid Message-Id?
>
> Stricly speacking, it is not an invalid Message-Id. RFC 2822 says that
> the Message-Id has to be unique. The right hand side may not contain a
> domain identifier. It is a RECOMMENDED practice (a good one, though).

It also says that (3.6.4):
   The message identifier (msg-id) is similar in syntax to an angle-addr
   construct without the internal CFWS.

And defines:
   message-id      =       "Message-ID:" msg-id CRLF
   msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]

So, the domain part *is* required (or at least: there has to be a "@"; it maybe does not require id-right to be an actual domain, but that's not really relevant here).

So, IMO inn2's check is correct.