Re: git-send-email generates mail with invalid Message-Id

From

NSNicolas Sebrecht <nicolas.s.dev@gmx.fr>

Date

Jul 28, 2009, 15:07 UTC

Message-ID

<20090728150745.GB16168@vidovic>

In-Reply-To

<40aa078e0907280510s1afee3ddw3a9333620a3c7d7a@mail.gmail.com>

The 28/07/09, Erik Faye-Lund wrote:

> 
> Here's an attempt to fix the case when Sys::Hostname::hostname returns
> "" (domains aren't allowed to be empty if I read RFC2822 correctly).
>
> The problem with the previous attempt was that the earlier if assigned
> "user@" to $du_part, so the last if was never entered ($du_part was
> always defined).

Yes, thank you.

> I generally don't write Perl, so people will most likely barf all over
> this one, but at least it should show the concept. It might not even
> work.

Looks ok here.

> I also suspect that it is not needed.

-- 
Nicolas Sebrecht