Re: git-send-email generates mail with invalid Message-Id

From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Date: Jul 28, 2009, 11:38 UTC
Message-ID: <20090728113814.GB12947@vidovic>
In-Reply-To: <200907281313.51304.elendil@planet.nl>

The 28/07/09, Frans Pop wrote:

Show 20 quoted lines

> On Tuesday 28 July 2009, you wrote:
> > Erik Faye-Lund wrote:
> >
> > Stricly speacking, it is not an invalid Message-Id. RFC 2822 says that
> > the Message-Id has to be unique. The right hand side may not contain a
> > domain identifier. It is a RECOMMENDED practice (a good one, though).
> 
> It also says that (3.6.4):
>    The message identifier (msg-id) is similar in syntax to an angle-addr
>    construct without the internal CFWS.
> 
> And defines:
>    message-id      =       "Message-ID:" msg-id CRLF
>    msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]
> 
> So, the domain part *is* required (or at least: there has to be a "@"; it 
> maybe does not require id-right to be an actual domain, but that's not 
> really relevant here).
> 
> So, IMO inn2's check is correct.

Hum, you're right. The '@' symbol is required, whatever "id-right" is. My previous patch should fix it.

-- 
Nicolas Sebrecht