git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add compat/setenv.c, use in git.c.

From
Jason Riedy <ejr@eecs.berkeley.edu>
Date
Dec 6, 2005, 22:18 UTC
Message-ID
<20475.1133907505@lotus.CS.Berkeley.EDU>
In-Reply-To
<7vwtih299f.fsf@assigned-by-dhcp.cox.net>
And Morten Welinder writes:
 - The code looks wrong.  It assumes that pointers are no larger than ints.

The failure's in 32-bit mode, so they _are_ the same size. The difference is no more than 0x80 in the tests.

But you're right; the result is implementation defined in C99.

And Junio C Hamano writes:
 - Are you suggesting it to be done like this?

Your change fixed it. Oddly enough, using arithmetic in ptrdiff_t then testing against zero didn't... I don't have time to dig through assembly or try different gcc versions to figure out the real problem. ugh.

Jason
Previous: Junio C HamanoNext: Morten Welinder
Message 13 of 15 in “Add compat/setenv.c, use in git.c.”
  1. Add compat/setenv.c, use in git.c.Jason Riedy, Dec 2, 2005
  2. Junio C HamanoDec 4, 2005
  3. H. Peter AnvinDec 4, 2005
  4. Junio C HamanoDec 4, 2005
  5. Junio C HamanoDec 4, 2005
  6. H. Peter AnvinDec 4, 2005
  7. Jason RiedyDec 5, 2005
  8. H. Peter AnvinDec 5, 2005
  9. Junio C HamanoDec 6, 2005
  10. Jason RiedyDec 6, 2005
  11. Morten WelinderDec 6, 2005
  12. Junio C HamanoDec 6, 2005
  13. Jason RiedyDec 6, 2005
  14. Morten WelinderDec 7, 2005
  15. compat/setenv: do not free what we fed putenv(3).Junio C Hamano, Dec 4, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.