Re: [PATCH] Add compat/setenv.c, use in git.c.

From: Junio C Hamano <junkio@cox.net>
Date: Dec 6, 2005, 03:35 UTC
Message-ID: <7vslt67v9o.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <14404.1133806037@lotus.CS.Berkeley.EDU>

Jason Riedy <ejr@EECS.Berkeley.EDU> writes:

Show 9 quoted lines

> And Junio C Hamano writes:
>  - putenv(3) says
>  - 	The string pointed to by string becomes part of the environment,
>  - 	so altering the string changes the environment.
>
> Good catch, thanks.  The Solaris man page first says the 
> string space is "no longer used", but at the very end warns 
> against using an automatic variable.  Chalk one up for lousy 
> docs.

Same thing for 5.9.

With the "compat update" patch from last night, I managed to build on a borrowed sparc with Solaris 5.9, but I needed NO_SETENV myself. I'd like to throw in another Makefile patch to catch both 5.8 and 5.9 for this, but would appreciate if people with various vintage of Solaris boxes can give some inputs before doing that.

This was done with somewhat stripped down configuration. I had to say NO_EXPAT, libiconv was needed but iconv and openssl were installed at nonstandard places, python was 2.3 so I also said PYTHON_PATH and WITH_OWN_SUBPROCESS_PY from the make command line. But the borrowed box is not what I administer myself, so I declare victory for now.