git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add compat/setenv.c, use in git.c.

From
Junio C Hamano <junkio@cox.net>
Date
Dec 4, 2005, 22:24 UTC
Message-ID
<7vy830ec15.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<43935A9E.2060602@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
> Wouldn't this be a good case for using alloca()?

Perhaps, but considering that (1) this function is not something frequently called anyway, and (2) the proposed change would make it the first alloca() user, and (3) this is compatibility replacement function, I'd rather choose to keep it "old, known to work at more places" malloc/free pair, and not having to worry about it.

But now you quote the patch, sizeof(char) looks funny. Isn't it always 1 by definition?

Previous: H. Peter AnvinNext: Junio C Hamano
Message 4 of 15 in “Add compat/setenv.c, use in git.c.”
  1. Add compat/setenv.c, use in git.c.Jason Riedy, Dec 2, 2005
  2. Junio C HamanoDec 4, 2005
  3. H. Peter AnvinDec 4, 2005
  4. Junio C HamanoDec 4, 2005
  5. Junio C HamanoDec 4, 2005
  6. H. Peter AnvinDec 4, 2005
  7. Jason RiedyDec 5, 2005
  8. H. Peter AnvinDec 5, 2005
  9. Junio C HamanoDec 6, 2005
  10. Jason RiedyDec 6, 2005
  11. Morten WelinderDec 6, 2005
  12. Junio C HamanoDec 6, 2005
  13. Jason RiedyDec 6, 2005
  14. Morten WelinderDec 7, 2005
  15. compat/setenv: do not free what we fed putenv(3).Junio C Hamano, Dec 4, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.