From: Jason Riedy <ejr@eecs.berkeley.edu>
Date: Tue, 06 Dec 2005 22:18:25 GMT
Subject: Re: [PATCH] Add compat/setenv.c, use in git.c.
Message-ID: <20475.1133907505@lotus.CS.Berkeley.EDU>
In-Reply-To: <7vwtih299f.fsf@assigned-by-dhcp.cox.net>

And Morten Welinder writes:
 - The code looks wrong.  It assumes that pointers are no larger than ints.

The failure's in 32-bit mode, so they _are_ the same size.
The difference is no more than 0x80 in the tests.

But you're right; the result is implementation defined in
C99.

And Junio C Hamano writes:
 - Are you suggesting it to be done like this?

Your change fixed it.  Oddly enough, using arithmetic in
ptrdiff_t then testing against zero didn't...  I don't
have time to dig through assembly or try different gcc
versions to figure out the real problem.  ugh.

Jason