Re: [PATCH] Add compat/setenv.c, use in git.c.

The code looks wrong. It assumes that pointers are no larger than ints. If pointers are larger than ints, the code does not necessarily compute a consistent ordering and qsort is allowed to do whatever it wants.

Morten

static int compare_object_pointers(const void *a, const void *b)
{
	const struct object * const *pa = a;
	const struct object * const *pb = b;
	return *pa - *pb;
}