From: Vsevolod Myalitsin <ub4nal@mail.ru>
Date: Thu, 17 Sep 2026 14:03:50 GMT
Subject: Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism
Message-ID: <20260917140350.44760-1-ub4nal@mail.ru>
In-Reply-To: <xmqq33vb4hma.fsf@gitster.g>

Junio C Hamano writes:
> So to conclude the topic, we would only need this?

Yes, I think this is indeed where we were heading.

However, during the discussion I really liked the idea of passing a pointer to the "advice_setting" to "vadvise()" instead of passing its individual fields. It seems like a cleaner interface, even though it is not directly related to this fix.

Would it make sense to submit that change as a separate patch?