From: Shardul Natu <snatu@google.com>
Date: Wed, 08 Jul 2026 03:15:52 GMT
Subject: Re: [PATCH v7 3/3] contrib: wire up osxkeychain in contrib/Makefile on macOS
Message-ID: <20260708031552.157939-1-snatu@google.com>
In-Reply-To: <xmqqmrw3aoas.fsf@gitster.g>

> Is $(uname_S) defined here at this point with only the above two
> includes?  Don't you need to include ../config.mak.uname as well?
> 
> The top-level Makefile does this:
> 
>         include config.mak.uname
>         -include config.mak.autogen
>         -include config.mak
> 
> and so should this one, I think, in exactly the same order.

Ah, yes. I have updated the include sequence in contrib/Makefile to:
  include ../config.mak.uname
  -include ../config.mak.autogen
  -include ../config.mak