git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] commit: remove deprecated functions

From
Jeff King <peff@peff.net>
Date
Jun 2, 2026, 06:23 UTC
Message-ID
<20260602062322.GB695568@coredump.intra.peff.net>
In-Reply-To
<xmqqa4te91g7.fsf@gitster.g>
On Mon, Jun 01, 2026 at 04:14:48PM +0900, Junio C Hamano wrote:
Show 15 quoted lines
> > This looks obviously correct to me, but the whole topic made me wonder:
> > was it worth retaining the old names and deprecating them, versus just
> > removing them back then?
> >
> > Topics in flight would have needed an update then, but they did
> > eventually anyway. So it feels like the total amount of work done is
> > larger, compared to just fixing them as the topics were merged. Either
> > way the compiler tells us, and the adjustments themselves are small.
> 
> Your alternative approach will depend on the integrator doing all
> the fixups at the merge time.
> 
> The amount of effort required by the entire community as a whole may
> have been larger, but the way the rename was carried out did spread
> them thinner.
True, though my thinking was two-fold:
  - Topics in flight that you _haven't_ picked up yet are not your
    problem. They become the problem of their authors, as long as they
    build on top of the change in question (either originally, or via
    rebase).
  - It's also work to pick up the new topic. So there's some tradeoff
    for the maintainer in how many fixups (and how much effort for each
    one) versus the work to juggle a new topic.
Show 7 quoted lines
> Admittedly, with help from rerere and merge-fix mechanism, such a
> "fixup at the merge time" typically needs to be done only once per
> the other conflicting topic in flight, but still, when constructing
> a workflow, I try to avoid having to depend on the single bottleneck
> for a task that does not need to be performed by the single
> bottleneck, especially when the single bottleneck has other tasks
> that can only be done by the single bottleneck.

Yeah, I think that is a good philosophy in general. I just wondered whether the tradeoff was right here (but I'm happy to defer to you for the final call on that).

-Peff
Previous: Junio C Hamano
Message 13 of 13 in “commit: remove deprecated functions”
  1. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  2. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 27, 2026
  3. Patrick SteinhardtMay 28, 2026
  4. Kristoffer HaugsbakkMay 28, 2026
  5. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  6. Patrick SteinhardtMay 28, 2026
  7. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  8. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 28, 2026
  9. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  10. Jeff KingMay 29, 2026
  11. Patrick SteinhardtJun 1, 2026
  12. Junio C HamanoJun 1, 2026
  13. Jeff KingJun 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.