From: Jeff King Date: Tue, 02 Jun 2026 06:23:22 GMT Subject: Re: [PATCH v2 0/2] commit: remove deprecated functions Message-ID: <20260602062322.GB695568@coredump.intra.peff.net> In-Reply-To: On Mon, Jun 01, 2026 at 04:14:48PM +0900, Junio C Hamano wrote: > > This looks obviously correct to me, but the whole topic made me wonder: > > was it worth retaining the old names and deprecating them, versus just > > removing them back then? > > > > Topics in flight would have needed an update then, but they did > > eventually anyway. So it feels like the total amount of work done is > > larger, compared to just fixing them as the topics were merged. Either > > way the compiler tells us, and the adjustments themselves are small. > > Your alternative approach will depend on the integrator doing all > the fixups at the merge time. > > The amount of effort required by the entire community as a whole may > have been larger, but the way the rename was carried out did spread > them thinner. True, though my thinking was two-fold: - Topics in flight that you _haven't_ picked up yet are not your problem. They become the problem of their authors, as long as they build on top of the change in question (either originally, or via rebase). - It's also work to pick up the new topic. So there's some tradeoff for the maintainer in how many fixups (and how much effort for each one) versus the work to juggle a new topic. > Admittedly, with help from rerere and merge-fix mechanism, such a > "fixup at the merge time" typically needs to be done only once per > the other conflicting topic in flight, but still, when constructing > a workflow, I try to avoid having to depend on the single bottleneck > for a task that does not need to be performed by the single > bottleneck, especially when the single bottleneck has other tasks > that can only be done by the single bottleneck. Yeah, I think that is a good philosophy in general. I just wondered whether the tradeoff was right here (but I'm happy to defer to you for the final call on that). -Peff