git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] commit: remove deprecated functions

From
Patrick Steinhardt <ps@pks.im>
Date
Jun 1, 2026, 05:58 UTC
Message-ID
<ah0fahsc-a6JvYi-@pks.im>
In-Reply-To
<20260529083716.GE1106035@coredump.intra.peff.net>
On Fri, May 29, 2026 at 04:37:16AM -0400, Jeff King wrote:
Show 16 quoted lines
> On Thu, May 28, 2026 at 09:00:09AM +0200, kristofferhaugsbakk@fastmail.com wrote:
> 
> > Topic summary: Remove deprecated comments that were slated for removal
> > after Git 2.53.0.
> 
> This looks obviously correct to me, but the whole topic made me wonder:
> was it worth retaining the old names and deprecating them, versus just
> removing them back then?
> 
> Topics in flight would have needed an update then, but they did
> eventually anyway. So it feels like the total amount of work done is
> larger, compared to just fixing them as the topics were merged. Either
> way the compiler tells us, and the adjustments themselves are small.
> 
> Not a huge deal either way, but just pondering for future such
> situations.

Yeah, I'm always very torn on these myself. I guess ultimately it's always going to be dependent on the actual refactoring: the bigger the blast radius, the more it makes sense to have a transition period so that we don't break in-flight patch series.

Where exactly that line is is a different question of course.
Patrick
Previous: Jeff KingNext: Junio C Hamano
Message 11 of 13 in “commit: remove deprecated functions”
  1. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  2. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 27, 2026
  3. Patrick SteinhardtMay 28, 2026
  4. Kristoffer HaugsbakkMay 28, 2026
  5. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  6. Patrick SteinhardtMay 28, 2026
  7. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  8. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 28, 2026
  9. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  10. Jeff KingMay 29, 2026
  11. Patrick SteinhardtJun 1, 2026
  12. Junio C HamanoJun 1, 2026
  13. Jeff KingJun 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.