git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] *: replace deprecated free_commit_list

From
Patrick Steinhardt <ps@pks.im>
Date
May 28, 2026, 05:24 UTC
Message-ID
<ahfRdFXJf9SRaz5q@pks.im>
In-Reply-To
<commit.h_replace_deprecated.715@msgid.xyz>
On Wed, May 27, 2026 at 03:59:25PM +0200, kristofferhaugsbakk@fastmail.com wrote:
Show 19 quoted lines
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
> 
> Replace `free_commit_list` with `commit_list_free`. The former was
> deprecated in 9f18d089 (commit: rename `free_commit_list()` to conform
> to coding guidelines, 2026-01-15).
> 
> This allows us to remove all the deprecated functions in the
> next commit:
> 
> • `copy_commit_list`
> • `reverse_commit_list`
> • `free_commit_list`
> 
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>  builtin/history.c | 4 ++--
>  replay.c          | 2 +-
>  upload-pack.c     | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)

Heh. Funny to see that I introduced the new functions, and that I was also the one that continued using the old ones most :)

Patrick
Previous: kristofferhaugsbakk@fastmail.comNext: Kristoffer Haugsbakk
Message 3 of 13 in “commit: remove deprecated functions”
  1. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  2. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 27, 2026
  3. Patrick SteinhardtMay 28, 2026
  4. Kristoffer HaugsbakkMay 28, 2026
  5. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 27, 2026
  6. Patrick SteinhardtMay 28, 2026
  7. 0/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  8. 1/2 *: replace deprecated free_commit_listkristofferhaugsbakk@fastmail.com, May 28, 2026
  9. 2/2 commit: remove deprecated functionskristofferhaugsbakk@fastmail.com, May 28, 2026
  10. Jeff KingMay 29, 2026
  11. Patrick SteinhardtJun 1, 2026
  12. Junio C HamanoJun 1, 2026
  13. Jeff KingJun 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.