[PATCH v2 1/2] *: replace deprecated free_commit_list
- From
- kristofferhaugsbakk@fastmail.com <kristofferhaugsbakk@fastmail.com>
- Date
- May 28, 2026, 07:00 UTC
- Message-ID
- <V2_commit.h_replace_deprecated.733@msgid.xyz>
- In-Reply-To
- <V2_CV_commit.h_remove_deprecated.732@msgid.xyz>
From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Replace `free_commit_list` with `commit_list_free`. The former was deprecated in 9f18d089 (commit: rename `free_commit_list()` to conform to coding guidelines, 2026-01-15).
This allows us to remove all the deprecated functions in the next commit:
• `copy_commit_list` • `reverse_commit_list` • `free_commit_list`
Acked-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> ---
Notes (series):
v2: add ackbuiltin/history.c | 4 ++-- replay.c | 2 +- upload-pack.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/history.c b/builtin/history.c index 0fc06fb2045..091465a59e2 100644 --- a/builtin/history.c +++ b/builtin/history.c @@ -284,7 +284,7 @@ static int setup_revwalk(struct repository *repo, commit_list_insert(original, &from_list); ret = repo_is_descendant_of(repo, head, from_list); - free_commit_list(from_list); + commit_list_free(from_list); if (ret < 0) { ret = error(_("cannot determine descendance")); @@ -892,7 +892,7 @@ static int split_commit(struct repository *repo, if (index_file.len) unlink(index_file.buf); strbuf_release(&index_file); - free_commit_list(parents); + commit_list_free(parents); release_index(&index); return ret; } diff --git a/replay.c b/replay.c index 4ef8abb6077..da531d5bc68 100644 --- a/replay.c +++ b/replay.c @@ -120,7 +120,7 @@ static struct commit *create_commit(struct repository *repo, out: repo_unuse_commit_buffer(repo, based_on, message); free_commit_extra_headers(extra); - free_commit_list(parents); + commit_list_free(parents); strbuf_release(&msg); free(author); return (struct commit *)obj; diff --git a/upload-pack.c b/upload-pack.c index 9f6d6fe48c8..2bf450ab288 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -886,7 +886,7 @@ static void deepen(struct upload_pack_data *data, int depth) data->deepen_relative, depth, SHALLOW, NOT_SHALLOW); send_shallow(data, result); - free_commit_list(result); + commit_list_free(result); } send_unshallow(data); @@ -900,7 +900,7 @@ static void deepen_by_rev_list(struct upload_pack_data *data, disable_commit_graph(the_repository); result = get_shallow_commits_by_rev_list(argv, SHALLOW, NOT_SHALLOW); send_shallow(data, result); - free_commit_list(result); + commit_list_free(result); send_unshallow(data); }
-- 2.54.0.16.g8f27b399cbe