Re: [PATCH 07/15] remote-mediawiki tests: guard test_cmp with test_path_is_file

From: Jeff King <peff@peff.net>
Date: Sep 16, 2020, 18:41 UTC
Message-ID: <20200916184104.GB33925@coredump.intra.peff.net>
In-Reply-To: <20200916102918.29805-8-avarab@gmail.com>

On Wed, Sep 16, 2020 at 12:29:10PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Change a test that used a plain test_cmp to first check the file(s)
> using test_path_is_file. If some of these file(s) don't exist (as
> happened to me during debugging), test_cmp will emit a way less useful
> message about the failure.

This seems like a problem that would exist in basically every test that uses test_cmp (well, many of them do ">actual", so it's unlikely that the content would be missing, but it would be true of any test that expects a command to generate a file).

Rather than annotate each site, could we teach test_cmp to show a nicer message?

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.