Re: [PATCH 00/15] remote-mediawiki: various fixes to make tests pass

From: Jeff King <peff@peff.net>
Date: Sep 16, 2020, 18:57 UTC
Message-ID: <20200916185732.GE33925@coredump.intra.peff.net>
In-Reply-To: <20200916102918.29805-1-avarab@gmail.com>

On Wed, Sep 16, 2020 at 12:29:03PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> I had occasion to look at remote-mediawiki and I couldn't even get the
> test suite to run. The patches below have more detail but there's
> issues like a hard error on any Perl release newer than ones released
> in 2013, and the MediaWiki release it tries to use spewing errors on
> any modern PHP version.
> 
> This series fixes these issues. With it applied it's possible to run
> the tests, and they all pass.

These all look reasonable. I left a few minor comments, but frankly, I care little enough about this clearly unmaintained bit of contrib/ that I would be happy either way.

I am a little puzzled about what we want the future of contrib/mw-to-git to be. It sounds like there have been a few minor improvements in the external GitHub project (though clearly lacking a bunch of fixes you have here). Should we be pushing these fixes up to that version and then either:

  - considering that project the upstream, and reimporting from them
    once the fixes are merged there

  - ejecting it from contrib/; it can live on as a separate project

-Peff